Data persistence in candidate views #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlovesgithub
temporarily deployed
to
develop
GitHub Actions
Inactive
|
Visit the preview URL for this PR (updated for commit dd8d9d9): https://jac-admin-develop--pr2613-bugfix-candidate-det-uncycwwu.web.app (expires Sat, 28 Dec 2024 10:37:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
tomlovesgithub
temporarily deployed
to
production
GitHub Actions
Inactive
|
Visit the preview URL for this PR (updated for commit 5522b6c): https://jac-apply-admin-production--pr2613-bugfix-candidate-de-9m629uc9.web.app (expires Wed, 25 Dec 2024 15:19:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2f31b7832d58b04f07d3816f45a5d09d461ded5e |
tomlovesgithub
temporarily deployed
to
develop
GitHub Actions
Inactive
tomlovesgithub
temporarily deployed
to
develop
GitHub Actions
Inactive
HalcyonJAC
approved these changes
Nov 25, 2024
tomlovesgithub
temporarily deployed
to
develop
GitHub Actions
Inactive
|
@tomlovesgithub can you make the testing instructions a bit clearer then I'll test it and code review it? cheers |
NormaJAC
approved these changes
Nov 28, 2024
tomlovesgithub
temporarily deployed
to
develop
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Details in the candidate view, (Character Information, Equality and Diversity) were getting stuck when looking through different individuals, in circumstances when there were no answers.
(ie. candidate A has answers for Char Info and E&D survey, Candidate B has none, Navigating to candidate A, then to Candidate B, you see candidate A's answers for Char Info and E&D).
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Ensure no answers persist when looking through different candidates.
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING